Provide sha256 checksum with file updates #1353
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rampageservices
suggested changes
Dec 5, 2023
| @@ -1725,6 +1726,10 @@ def send_file(self, request, stream, labels, buffer = '', throttle = 0, | |||
| sha256_hash = checksum_sha256_file(stream, offset, size_total) | |||
| request.body = sha256_hash | |||
|
|
|||
| # Provide the checksum with teh request. This is important for buckets that have | |||
There was a problem hiding this comment.
"the" is spelled incorrectly here, shown as "teh". Minor typo.
| @@ -1725,6 +1726,10 @@ def send_file(self, request, stream, labels, buffer = '', throttle = 0, | |||
| sha256_hash = checksum_sha256_file(stream, offset, size_total) | |||
| request.body = sha256_hash | |||
|
|
|||
| # Provide the checksum with teh request. This is important for buckets that have | |||
| # Object Lock enabled. | |||
| headers['x-amz-checksum-sha256'] = base64.b64encode(sha256_hash.digest()).decode() | |||
There was a problem hiding this comment.
base64.b64encode(sha256_hash.digest()).decode()
Can this line be broken down? It is doing a lot all at once. It is hard for readability.
Perhaps we canpull out the digest operation into a separate sha256_hash_digest variable?
Or maybe this functionality can be separated into a new function in S3/Crypto.py
I know this exact line is recommended online in tutorials but is in my opinion hard to read.
See: https://debugpointer.com/python/sha256-to-base64-python
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1177. I tried
Content-MD5as well, but that was more involved.