Sidebar shows previous/next links with inconsistent format

[datapythonista]

I'm working on using this theme for the pandas documentation, and I'm getting something which seems wrong in the sidebar (see attachment).

The links to the previous and next sections seem to lack css formatting. Not even sure why they appear, as they are not in the theme examples and I don't see anything on my config to show them.

You can see the conf.py file I'm using here: https://github.com/datapythonista/pandas/blob/doc_home/doc/source/conf.py

And the page rendered here: https://datapythonista.github.io/docs/new-pandas-doc/overview.html

Thanks! And thanks for the amazing work with this theme, pandas documentation will look amazing with it. :)

[svenevs]

To clarify, yes you want the "next" and "previous" pages to link, or no you do not?

https://github.com/datapythonista/pandas/blob/bd95c4b9f99b15d222461b29363452706934b59d/doc/source/conf.py#L205

That should be making them go away...meaning we have a problem here...

Edit wait a second, no that only affects the navbar sorry. I'm looking through our templates right now, the <ul> is getting ended too early...

[svenevs]

Ok I've found the problem but I'm not sure what the solution is. It's coming from relations.html.

It seems we've been deprecated, though I don't know what the new world order is: https://github.com/sphinx-doc/sphinx/blob/1c3eadcf61ab2725801218b207640bc7634b0f8f/sphinx/themes/basic/layout.html#L67

The issue is that there is a discrepancy between the use-cases of relations.html, how we use it in the navbar (the bare <li> are OK), and how it is now being added to the sidebar (bare <li> is not OK, since the <ul> already got ended [somehow...]). I'm going to see if I can get a band-aid working for this later tonight.

[ashafer01]

I think its entirely up to the user's conf.py whether or not the sidebar is old or new style. And for the purposes of this issue, commenting out the definition I suspect is what triggered the old-style behavior.

It looks like the way our layout.html is written fully expects that the conf.py contains a new-style definition (such as mine). I think my PR (#182) coupled with a doc update mentioning this is the way to go.

[johentsch]

This issue appeared for me after upgrading to the current sphinx==7.3.7. Notably, with all versions between 5.3.0 and 7.2.0 that I've tried, my page never used to have a sidebar at all. With the latest version, suddenly I have a new sidebar and it has the 'previous' and 'next' links screwed as reported here. The same problem exists on the sphinx-themes.org.

Since I never wanted the sidebar in the first place, how can I deactivate it, please? The documentation does not contain the strings sidebar nor side bar.