Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
rx_fm
not working with rtlsdr (fixes #90 )SoapySDRDevice_setGainMode
was called afterSoapySDRDevice_setGain
, that seems to reset gain to 0. Likely due to https://github.com/steve-m/librtlsdr/blob/619ac3186ea0ffc092615e1f59f7397e5e6f668c/src/librtlsdr.c#L258C1-L261C2 :i.e. gain value is reset to 0 when
rtlsdr_set_tuner_gain_mode
is called2. Remove rtlagc option as it's not needed anymore.
With these changes I get identical output from
rtl_fm
andrx_fm
with both auto and manual gains e.g.