Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand allowed data capacity for barcodes if size constraints allow #5

Open
hschimke opened this issue Feb 13, 2023 · 2 comments
Open

Expand allowed data capacity for barcodes if size constraints allow #5

hschimke opened this issue Feb 13, 2023 · 2 comments
Assignees
@hschimke
Labels
enhancement New feature or request

Comments

@hschimke
Copy link
Collaborator

https://www.reddit.com/r/rust/comments/1117fpk/comment/j8ea409/?utm_source=share&utm_medium=web2x&context=3
@hschimke hschimke added the enhancement New feature or request label Feb 13, 2023
@hschimke hschimke self-assigned this Feb 13, 2023
@hschimke
Copy link
Collaborator Author

Looking at this, it appears that we should support up to version 40. I tested with default settings and adding a 1kb file and RXing-cli errors with “data too large to encode”. I believe that this is due to either the estimate_size or pick_version helpers in the QRCode encoder module.

@hschimke
Copy link
Collaborator Author

hschimke commented Mar 6, 2023

Needs a test case, it looks as if the provisional test for size might not account for varying ec levels, when no ec level has been specified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hschimke hschimke

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hschimke