Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Evaluate moving to encoding_rs #4

Open
hschimke opened this issue Feb 7, 2023 · 2 comments
Open

Evaluate moving to encoding_rs #4

hschimke opened this issue Feb 7, 2023 · 2 comments
Assignees
@hschimke
Labels
enhancement New feature or request

Comments

@hschimke
Copy link
Collaborator

hschimke commented Feb 7, 2023

As encoding crate hasn't been updated in some time, there may be a benefit I using a more frequently updated crate. A feasibility analysis is needed.
@hschimke hschimke added the enhancement New feature or request label Feb 7, 2023
@hschimke hschimke self-assigned this Feb 7, 2023
@hschimke
Copy link
Collaborator Author

This is tightly related to #16

@hschimke
Copy link
Collaborator Author

hschimke commented Aug 2, 2024

encoding_rs does not handle ISO-8859-1, which is required for the library to correctly function. Currently encoding_rs alone is not a valid solution to the issue. However, the decoupling between the library and rxing is now nearly complete, so if a solution which does handle ISO-8859-1 arrives then it is relatively trivial to switch away from the encoding crate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hschimke hschimke

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hschimke