Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruby Sass End of Life #231

Open
dillonwelch opened this issue Sep 24, 2018 · 6 comments
Open

Ruby Sass End of Life #231

dillonwelch opened this issue Sep 24, 2018 · 6 comments

Comments

@dillonwelch
Copy link

rails/rails#32896

rails/sass-rails#420

Looks like sass-rails is being end of life'd on 26 March 2019.

@xinlangzi
Copy link

This gem has dependency sass_rails which use sass too. Ruby Sass is deprecated and will be unmaintained as of 26 March 2019. Will you update dependency to use sassc_rails? Thank you.

http://sass.logdown.com/posts/7081811

marlinpierce added a commit to marlinpierce/jquery-datatables-rails that referenced this issue Jan 13, 2019
@marlinpierce
Copy link

I have forked this repo with a version that replaces the sass-rails dependency with sassc-rails. People are welcome to use it.

https://github.com/marlinpierce/jquery-datatables-rails

@jakeonfire
Copy link

@marlinpierce do you want to create a PR? perhaps it would be considered then.

@marlinpierce
Copy link

marlinpierce commented Jan 30, 2019

@jakeonfire I already created a PR, 12 days before you posted.

@marlinpierce
Copy link

Here's an approach which we might be doing at our company.

The only things that the jquery-datatables-rails gem does is:

  1. Package the datatables javascript plugin.
  2. Include dependencies to set up the backend for rails development using datatables.
  3. Provide some generators.

The first can be accomplished by replacing jquery-datatables-rails with jquery-datatables. This will update the datatables javascript from 1.10.10 from year 2015 to 1.10.19 from 2018. The paths are different, so you will have to change your asset pipeline manifests.

For the second, just add the gems in the dependency. So replace

gem 'jquery-datatables-rails', '~> 3.4.0'

with

gem "jquery-rails", '~> 4.3'
gem "sassc-rails", '~> 2.0'
gem 'jquery-datatables', '~> 1.10.19'

@marlinpierce
Copy link

This may eventually become a non-issue. The rails-sass gem is being updated with 6.0.0 to just be a wrapper for rails-sassc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants