minmax: don't nest min/max in clamp to avoid -Wshadow warnings #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using clamp from minmax.h with -Wshadow (GCC 11 and 8, haven't tested others) generates a bunch of warnings because min and max both declare _a, _b vars. Store the result of min to a temporary variable instead of nesting the calls this way min's variables are not in scope of max. Signed-off-by: Jakub Kicinski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using clamp from minmax.h with -Wshadow (GCC 11 and 8, haven't tested others)
generates a bunch of warnings because min and max both declare _a, _b vars.
Store the result of min to a temporary variable instead of nesting the calls
this way min's variables are not in scope of max.
Signed-off-by: Jakub Kicinski [email protected]