Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(smhc): add smhc peripheral pins and fix some issues. #14

Merged
merged 1 commit into from
Oct 9, 2024
Merged

feat(smhc): add smhc peripheral pins and fix some issues. #14

merged 1 commit into from
Oct 9, 2024

Conversation

NanaHigh
Copy link
Contributor

@NanaHigh NanaHigh commented Oct 9, 2024

  • Add smhc peripheral sdc0~2 pins in d1.rs.
  • Fix fmt and document annotations issues.

@NanaHigh
feat(smhc): add smhc peripheral pins and fix some issues.
c53aa32 
+ Add smhc peripheral sdc0~2 pins in d1.rs.
+ Fix fmt and document annotations issues.

Signed-off-by: Yu Chongbing <[email protected]>
Placebo27
Placebo27 approved these changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@Placebo27 Placebo27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! SDC{0, 1, 2} pins are accord with section 9.7.3.2 'GPIO Multiplex Function' in the manual.

luojia65
luojia65 approved these changes Oct 9, 2024
View reviewed changes
Copy link
Member

@luojia65 luojia65 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luojia65 luojia65 merged commit 30d2929 into rustsbi:main Oct 9, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luojia65 luojia65 luojia65 approved these changes

@Placebo27 Placebo27 Placebo27 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NanaHigh @luojia65 @Placebo27