Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace rustler_bigint by a feature flag on rustler #601

Merged
merged 1 commit into from
Mar 12, 2024
Merged

Conversation

filmor
Copy link
Member

@filmor filmor commented Mar 12, 2024

No description provided.

Copy link
Member

@evnu evnu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :)

@evnu
Copy link
Member

evnu commented Mar 12, 2024

Do you think this requires some kind of deprecation notice in the released rustler_bigint crate? It doesn't seem that it has been downloaded a lot yet, so the impact is likely not large.

@filmor
Copy link
Member Author

filmor commented Mar 12, 2024

We could publish a version with a deprecation warning, yes. I don't see any need to rush this, though. The library will keep working even with this change and the necessary steps are listed in the UPDATE docs.

@filmor filmor merged commit 4bc7cf8 into master Mar 12, 2024
34 checks passed
@filmor filmor deleted the big-int-feature branch March 12, 2024 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants