Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dpi: add types for rectangles #3956

Open
jgcodes2020 opened this issue Oct 19, 2024 · 1 comment · May be fixed by #3972
Open

dpi: add types for rectangles #3956

jgcodes2020 opened this issue Oct 19, 2024 · 1 comment · May be fixed by #3972
Labels
S - enhancement Wouldn't this be the coolest?

Comments

@jgcodes2020
Copy link

Description

This will be necessary for #3928/#403.

Wayland has the most restrictive design for positioning popups; so attributes for popup position will roughly follow Wayland's xdg_positioner. This requires rectangles.

While you could just use dpi::Position and dpi::Size, it's not nearly as idiomatic, and generally speaking, you want both position and size to be of the same type (physical/logical).

Relevant platforms

Windows, macOS, Wayland, X11, Web, iOS, Android

@jgcodes2020 jgcodes2020 added the S - enhancement Wouldn't this be the coolest? label Oct 19, 2024
@amrbashir
Copy link
Contributor

This would be a very nice addition IMO, currently for tauri, we have 3 different Rect in 3 different crates

@madsmtm madsmtm linked a pull request Oct 25, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S - enhancement Wouldn't this be the coolest?
Development

Successfully merging a pull request may close this issue.

2 participants