Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IME callback crashes application #3875

Open
abhishekp106 opened this issue Aug 16, 2024 · 2 comments
Open

IME callback crashes application #3875

abhishekp106 opened this issue Aug 16, 2024 · 2 comments
Labels
B - bug Dang, that shouldn't have happened DS - x11

Comments

@abhishekp106
Copy link

abhishekp106 commented Aug 16, 2024

Description

The application I'm developing that depends on winit crashes here. My application panics with Invalid UTF-8 String from IME: Utf8Error { valid_up_to: 0, error_len: Some(1) }. It seems to be due to the IME String failing to be proper UTF-8. Is there a way winit could fail in a safer way than crashing here?

I don't have a repro as this happened on another user's machine.

OS and window mananger

Operating System: Ubuntu
Window Manager: XWayland

Winit version

0.30.1

@abhishekp106 abhishekp106 added B - bug Dang, that shouldn't have happened DS - x11 labels Aug 16, 2024
@notgull
Copy link
Member

notgull commented Aug 22, 2024

This will be fixed in the upcoming refactoring of IME in X11.

@kchibisov
Copy link
Member

Maybe just discard the invalid values? Not sure how doing lossy conversion will work here, maybe just fine...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B - bug Dang, that shouldn't have happened DS - x11
Development

No branches or pull requests

3 participants