Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

License clarification #136

Open
dm0- opened this issue Mar 9, 2023 · 3 comments
Open

License clarification #136

dm0- opened this issue Mar 9, 2023 · 3 comments

Comments

@dm0-
Copy link

dm0- commented Mar 9, 2023

I was reviewing crate licenses and encountered a conflict here: The README says the project is dual-licensed (i.e. an OR relation where either license can be chosen), but Cargo.toml and every source file's SPDX identifier declare an AND relation (i.e. the terms of both licenses must be satisfied simultaneously). Which is intended? Can the relevant file(s) please be fixed?

@andreeaflorescu
Copy link
Member

Yes, this needs to be fixed. The correct license is with OR, but depending on where the code originates from, we might need to keep it as BSD-3-Clause only. See discussion on rust-vmm/vmm-sys-util#161.

I can submit a PR with the fix.

@rbradford
Copy link
Collaborator

I think the SPDX data in the files are correct. The code is a mixture (so AND) not licensed equally under both (OR). It would require some work to move it to solely BSD-3-Clause or a true dual licensed version.

@andreeaflorescu
Copy link
Member

Right, I think we need something similar to what we did for vmm-sys-util: rust-vmm/vmm-sys-util#167. The initial code was derived from Crosvm, so that is BSD-3-Clause, so that's why I think it would be easier to have it as BSD-3-Clause because we would need agreement from the authors of the patches added on top to switch them to BSD-3-Clause instead. From our side, we are ok with updating the license as this is in the end compatible with the projects where we are using it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants