Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separation of Scalar trait into another crate #139

Merged
merged 11 commits into from
Apr 27, 2019
Merged

Separation of Scalar trait into another crate #139

merged 11 commits into from
Apr 27, 2019

Conversation

termoshtt
Copy link
Member

@termoshtt termoshtt commented Apr 25, 2019 •
edited
Loading

Split Scalar trait to rust-math/cauchy

Objective

  • Scalar trait itself is useful without LAPACK binding
  • It is hard to deal with the dependency to ndarray-linalg due to LAPACK FFI

Summay

  • ndarray-linalg::Scalar is split into two part: cauchy::Scalar and ndarray-linalg::Lapack traits
  • Separated traits (e.g. AssociatedReal, Conjugate, ...) are unified into cauchy::Scalar
  • RandNormal trait is replace to rand::distributions::Standard through rand feature of num-complex

@termoshtt termoshtt changed the title Split Scalar trait into anotehr crate Separation of Scalar trait into another crate Apr 25, 2019
@termoshtt termoshtt merged commit 4ca2a67 into master Apr 27, 2019
@termoshtt termoshtt deleted the cauchy branch April 27, 2019 12:12
termoshtt added a commit that referenced this pull request Apr 27, 2019
@termoshtt
CHANGELOG for #139
87bba67
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@termoshtt