Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump cc dependency #130720

Closed
wants to merge 1 commit into from
Closed

Bump cc dependency #130720

wants to merge 1 commit into from

Conversation

arttet
Copy link
Contributor

@arttet arttet commented Sep 22, 2024 •
edited by onur-ozkan
Loading

Closes #130719

try-job: x86_64-msvc

@rustbot
Copy link
Collaborator

rustbot commented Sep 22, 2024

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 22, 2024
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rustbot
Copy link
Collaborator

rustbot commented Sep 22, 2024

These commits modify the library/Cargo.lock file. Unintentional changes to library/Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@arttet arttet force-pushed the fix/profiler_builtins branch 2 times, most recently from a109243 to 1265643 Compare September 23, 2024 10:28
@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Sep 23, 2024
@rustbot
Copy link
Collaborator

rustbot commented Sep 23, 2024

The list of allowed third-party dependencies may have been modified! You must ensure that any new dependencies have compatible licenses before merging.

cc @davidtwco, @wesleywiser

@arttet
Copy link
Contributor Author

arttet commented Sep 23, 2024

r? @onur-ozkan

@onur-ozkan
Copy link
Member

Library team should review this.

r? library

@rustbot
Copy link
Collaborator

rustbot commented Sep 23, 2024

Failed to set assignee to library: invalid assignee

Note: Only org members with at least the repository "read" role, users with write permissions, or people who have commented on the PR may be assigned.

@onur-ozkan
Copy link
Member

r? libs

@rustbot rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Sep 23, 2024
@rustbot rustbot assigned Amanieu and unassigned onur-ozkan Sep 23, 2024
@Amanieu
Copy link
Member

Amanieu commented Sep 23, 2024

@bors r+

@bors
Copy link
Contributor

bors commented Sep 23, 2024

📌 Commit 1265643 has been approved by Amanieu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 23, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 24, 2024
@bors
Auto merge of rust-lang#130720 - arttet:fix/profiler_builtins, r=Amanieu
d969b05 
Bump cc dependency

Closes [rust-lang#130719](rust-lang#130719)
@bors
Copy link
Contributor

bors commented Sep 24, 2024

⌛ Testing commit 1265643 with merge d969b05...

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Contributor

bors commented Sep 24, 2024

💔 Test failed - checks-actions

@bors bors removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Sep 24, 2024
@arttet arttet mentioned this pull request Sep 26, 2024
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 26, 2024
@bors
Auto merge of rust-lang#130898 - arttet:test/cc, r=<try>
13a134a 
Bump cc dependency

We cannot merge the [PR](rust-lang#130720)
Let's try merging an older version for a change.

rust-lang#130720 (comment)

try-job: x86_64-msvc
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 26, 2024
@bors
Auto merge of rust-lang#130898 - arttet:test/cc, r=<try>
ea47bea 
Bump cc dependency

We cannot merge the [PR](rust-lang#130720)
Let's try merging an older version for a change.

rust-lang#130720 (comment)

try-job: x86_64-msvc
@workingjubilee
Copy link
Member

@bors rollup=iffy

@workingjubilee
Copy link
Member

Oh, I somehow missed this was already

@bors rollup=never

@tgross35 tgross35 mentioned this pull request Sep 26, 2024
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 26, 2024
@bors
Auto merge of rust-lang#130908 - tgross35:update-cc, r=<try>
f42fb94 
[experiment] Update cc to 1.0.100

See rust-lang#130720, rust-lang#130898; try with the minimal version bump.

try-job: x86_64-msvc
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 26, 2024
@bors
Auto merge of rust-lang#130898 - arttet:test/cc, r=<try>
83e023e 
Bump cc dependency

We cannot merge the [PR](rust-lang#130720)
Let's try merging an older version for a change.

rust-lang#130720 (comment)

try-job: x86_64-msvc
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 27, 2024
@bors
Auto merge of rust-lang#130908 - tgross35:update-cc, r=<try>
9d55780 
[experiment] Update cc to 1.0.100

See rust-lang#130720, rust-lang#130898; try with the minimal version bump.

try-job: x86_64-msvc
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 27, 2024
@bors
Auto merge of rust-lang#130908 - tgross35:update-cc, r=<try>
ed664a2 
[experiment] Update cc to 1.0.100

See rust-lang#130720, rust-lang#130898; try with the minimal version bump.

try-job: x86_64-msvc
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 27, 2024
@bors
Auto merge of rust-lang#130908 - tgross35:update-cc, r=<try>
f1d03b0 
[experiment] Update cc to 1.0.100

See rust-lang#130720, rust-lang#130898; try with the minimal version bump.

try-job: x86_64-msvc
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 27, 2024
@bors
Auto merge of rust-lang#130908 - tgross35:update-cc, r=<try>
3bfb192 
[experiment] Update `cc` CI tests

See rust-lang#130720, rust-lang#130898; try with the minimal version bump.

try-job: x86_64-msvc
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 27, 2024
@bors
Auto merge of rust-lang#130908 - tgross35:update-cc, r=<try>
61e52cc 
[experiment] Update `cc` CI tests

See rust-lang#130720, rust-lang#130898; try with the minimal version bump.

try-job: x86_64-msvc
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request Sep 27, 2024
@workingjubilee
Rollup merge of rust-lang#130892 - tgross35:library-cargo-update, r=N…
081b946 
…oratrieb

Partially update `library/Cargo.lock`

Run `cargo update` in library but exclude updates to `cc` and to `compiler_builtins`. Exclusions were done because `cc` seems to have some issues updating [1], and `compiler_builtins` needs to be updated on its own.

Partially supersedes rust-lang#129538.

[1]: rust-lang#130720

try-job: x86_64-msvc
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Sep 27, 2024
@rust-timer
Unrolled build for rust-lang#130892
dd6e2c5 
Rollup merge of rust-lang#130892 - tgross35:library-cargo-update, r=Noratrieb

Partially update `library/Cargo.lock`

Run `cargo update` in library but exclude updates to `cc` and to `compiler_builtins`. Exclusions were done because `cc` seems to have some issues updating [1], and `compiler_builtins` needs to be updated on its own.

Partially supersedes rust-lang#129538.

[1]: rust-lang#130720

try-job: x86_64-msvc
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 27, 2024
@bors
Auto merge of rust-lang#130908 - tgross35:update-cc, r=<try>
d82723e 
[experiment] Update `cc` CI tests

See rust-lang#130720, rust-lang#130898; try with the minimal version bump.

try-job: x86_64-msvc
@tgross35 tgross35 mentioned this pull request Sep 27, 2024
Merged
@arttet arttet closed this Sep 27, 2024
@arttet arttet reopened this Sep 27, 2024
@arttet
Copy link
Contributor Author

arttet commented Sep 27, 2024

@bors try

@bors
Copy link
Contributor

bors commented Sep 27, 2024

⌛ Trying commit 522a53d with merge ddfac70...

bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 27, 2024
@bors
Auto merge of rust-lang#130720 - arttet:fix/profiler_builtins, r=<try>
ddfac70 
Bump cc dependency

Closes [rust-lang#130719](rust-lang#130719)

try-job: x86_64-msvc
@tgross35
Copy link
Contributor

FYI 1.1.22 was already tested, see the results at #130926 (comment)

@bors
Copy link
Contributor

bors commented Sep 27, 2024

☀️ Try build successful - checks-actions
Build commit: ddfac70 (ddfac706ad8c2f0ad73a05566c4a86fd64e248e7)

@tgross35
Copy link
Contributor

#130926 was merged (🎉) so this should be all set

@arttet
Copy link
Contributor Author

arttet commented Sep 28, 2024

Thank you!

@arttet arttet closed this Sep 28, 2024
@arttet arttet deleted the fix/profiler_builtins branch September 28, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Amanieu Amanieu

Labels
A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unknown architecture for macOS target when we build profiler_builtins
10 participants
@arttet @rustbot @rust-log-analyzer @onur-ozkan @Amanieu @bors @ChrisDenton @tgross35 @workingjubilee @Mark-Simulacrum