Bump ar_archive_writer to 0.3.2 #128564
Closed
Bump ar_archive_writer to 0.3.2 #128564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
|
These commits modify the If this was unintentional then you should revert the changes before this PR is merged. |
|
Looks like this is redundant if #128206 gets merged... |
|
Yeah. I would prefer only merging that PR. For prototyping without needing to build rust yourself you could add a direct ar_archive_writer dependency to cg_clif and using that one instead of the version from the sysroot. |
|
Closing in favor of #128206 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ar_archive_writer0.3.2 adds support for correctly adding Windows import libraries into archives - this is required to enableraw-dylibsupport in the Cranelift backend.r? @bjorn3