Could not find allowed package adler

[Makuo12]

I tried this code:

./x tidy

I expected to see it run without any issues

Instead, this happened: tidy error: could not find allowed package adler

Meta

rustc --version --verbose:

rustc 1.81.0 (eeb90cda1 2024-09-04)

Backtrace

tidy error: could not find allowed package `adler`
Remove from PERMITTED_DEPENDENCIES list if it is no longer used.
tidy error: Dependency for library not explicitly permitted: registry+https://github.com/rust-lang/crates.io-index#[email protected]

[jieyouxu]

./x tidy is not a valid subcommand. On a local checkout of latest master 01e2fff I cannot reproduce this failure. What commit are you on? Maybe try clearing the build cache and rebase on master?

I get

error: 'x.py' requires a subcommand but one was not provided
  [subcommands: build, b, check, c, clippy, fix, fmt, doc, d, test, t, miri, bench, clean, dist, install, run, r, setup, suggest, vendor, perf]

Usage: x.py <subcommand> [options] [<paths>...]

For more information, try '--help'.
Build completed unsuccessfully in 0:01:17

when I run to run ./x tidy from a fresh checkout.

[jieyouxu]

Is this in the context of #131574? Those version bumps are significant, possibly breaking, as evident by changing out a major version of the adler transitive dependency underneath.

[Makuo12]

I would roll back. Then ensure that only dependencies updates that don't affect the code are changed.

[jieyouxu]

To clarify, if T-libs is okay with those version bumps, and as long as adler2 is of an allowed license, we can update the permitted dependencies allowlist.

[jieyouxu]

As Trevor said in #131574 (comment), this is not a bug, this is a feature of permitted dependency checking, that we can manually update if it's permitted by relevant teams.