Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dealing with disabled tests #540

Open
pnkfelix opened this issue Aug 4, 2022 · 2 comments
Open

Dealing with disabled tests #540

pnkfelix opened this issue Aug 4, 2022 · 2 comments

Comments

@pnkfelix
Copy link
Member

pnkfelix commented Aug 4, 2022

Meeting proposal info

  • Title: dealing with disabled tests
  • Type: technical

Summary

We sometimes disable tests because some other component we don't control (e.g. LLVM) is causing them to fail; see e.g. rust-lang/rust#99853

But we should put structures/protocols in place to ensure that such tests are revisited in the future, rather than just lying unaddressed.

About this issue

This issue corresponds to a meeting proposal for the compiler team
steering meeting. It corresponds to a possible topic of
discussion. You can read more about the steering meeting procedure
here
.

Comment policy

These issues are meant to be used as an "announcements channel"
regarding the proposal, and not as a place to discuss the technical
details. Feel free to subscribe to updates. We'll post comments when
reviewing the proposal in meetings or making a scheduling decision.
In the meantime, if you have questions or ideas, ping the proposers
on Zulip (or elsewhere).

@pnkfelix pnkfelix changed the title (My meeting proposal) Dealing with disabled tests Aug 4, 2022
@apiraino
Copy link
Contributor

apiraino commented Sep 1, 2022

Also mention of rust-lang/rust#88520 as another example (iiuc the context of that issue)

@lqd
Copy link
Member

lqd commented Sep 23, 2022

Is the following in scope for that meeting: is it possible to ensure these optional components' tests are indeed executed on CI ? (Or is that more of a t-infra concern). I'm thinking of the needs-lld tests in particular, that we currently can run locally but not on CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants