Deny warnings in CI and add check-cfg directives #603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgross35
force-pushed
the
ci-deny-warnings
branch
9 times, most recently
from
02f0ea7
to
3a04f18
Compare
tgross35
force-pushed
the
ci-deny-warnings
branch
4 times, most recently
from
9999f16
to
7d8114f
Compare
Urgau
reviewed
May 6, 2024
Comment on lines
+13
to
14
| println!("cargo::rustc-check-cfg=cfg(feature, values(\"unstable\"))"); | ||
| println!("cargo:rustc-cfg=feature=\"unstable\""); |
There was a problem hiding this comment.
Should probably be replaced by a real custom config and not a faux Cargo feature, ie unstable and not feature = "unstable".
There was a problem hiding this comment.
This comes from libm so I could probably do it here rust-lang/libm#296
Thanks for the quick review
tgross35
added a commit
to tgross35/compiler-builtins
that referenced
this pull request
May 6, 2024
tgross35
added a commit
to tgross35/compiler-builtins
that referenced
this pull request
May 6, 2024
tgross35
added a commit
to tgross35/compiler-builtins
that referenced
this pull request
May 6, 2024
tgross35
added a commit
to tgross35/compiler-builtins
that referenced
this pull request
May 6, 2024
tgross35
changed the title
There are currently a lot of warnings printed in CI, mostly dead code. Update CI to deny warnings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are currently a lot of warnings printed in CI, a lot of which come from the new check config. Update CI to deny warnings.