Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update other GitHub actions #669

Merged

Conversation

workingjubilee
Copy link
Member

We started using [email protected] in #663 but the rest weren't so security critical so dependabot didn't bump them. Not having them "just" breaks a workflow or two. So bump them.

@workingjubilee
Copy link
Member Author

It seems it doesn't want to use a version of this workflow that isn't the version on master.

@@ -61,6 +61,7 @@ jobs:
run: |
# Bootstrap config
cat <<EOF > config.toml
change-id = 9999999
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seem to have worked? Maybe it's not seeing the config.toml file for some reason?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's also using actions/checkout@v3. It won't use the workflow file changes until they're merged.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I see! I get what you were saying now. This looks right to me so I guess we'll merge and see?

@workingjubilee workingjubilee merged commit 8c25756 into rust-lang:master Sep 14, 2024
39 of 41 checks passed
@workingjubilee workingjubilee deleted the update-other-github-actions branch September 14, 2024 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants