Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reject duplicate fields #248

Open
birkenfeld opened this issue Nov 5, 2018 · 2 comments
Open

reject duplicate fields #248

birkenfeld opened this issue Nov 5, 2018 · 2 comments

Comments

@birkenfeld
Copy link

In stm32-rs/stm32-rs#83 (comment) we found that duplicate fields in a register aren't rejected by svd2rust. (There are probably other duplicate conditions that could be caught, such as duplicate register names?)

I'll make the required changes, but I need to know if you want to handle this in svd-parser already, while reading the SVD, or in svd2rust, while generating the output?

@ryankurte
Copy link
Collaborator

Hey, thanks for the issue! I'm not sure where that should go tbqh, @adamgreig @japaric do you have any thoughts?

@burrbull
Copy link
Member

burrbull commented Nov 7, 2022

In my view it is better to check this in svd-parser with ValidationLevel::Strict

@burrbull burrbull transferred this issue from rust-embedded/svd2rust Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants