Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP : Implement a sortedmulti_a descriptor #641

Closed
wants to merge 1 commit into from

Conversation

Harshit933
Copy link
Contributor

This is mostly the copy of sortedmulti for now with some changes in the Terminal being MultiA instead of Multi and some max_satisfaction_witness_element and max_satisfaction_size as implemented in core.

Some Question that I have and I think we can implement it on the way in this PR.

  • How can we build_template and what exactly is a template?
  • How to calculate the script_size of sortedmulti_a.

Some other questions that I have about implementing sortedmulti_a inside tr like tr(c6...., sortedmulti_a(2, 5f...., 6e....). For now we build a taptree and consider the trees inside the tr like : tr(c6..., {pk(), pk()}. This means when I trying to build a tree for tr(c6...., sortedmulti_a(2, 5f...., 6e....) I am hitting an error with

`Result::unwrap()` on an `Err` value: Unexpected("sortedmulti_a(3 args) while parsing Miniscript")

One solution that I for now think is to implement a TrInner as we have inside Sh(). Am I on the right path?

This is the starting point of implementing a sortedmulti_a descriptor
valid for taproot descriptors.
@Harshit933 Harshit933 marked this pull request as draft February 19, 2024 13:47
@Harshit933
Copy link
Contributor Author

@sanket1729 @apoelstra sorry for the ping. But can you please tell me if this is the right way of approaching the porblem or is there a better aproach to this?
Thanks.

@Harshit933 Harshit933 marked this pull request as ready for review March 1, 2024 06:59
@Harshit933 Harshit933 marked this pull request as draft April 9, 2024 10:52
@Harshit933 Harshit933 closed this Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant