Add Fe32::ZERO const #185
Closed
Add Fe32::ZERO const #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apoelstra
reviewed
Jul 16, 2024
|
concept ACK, though several of the changes from Q to ZERO I think make the code less clear. |
|
Reverted some of the renames as requested. |
apoelstra
approved these changes
Jul 16, 2024
|
Thanks for your contribution but NACK from me. How is this better than using |
|
I also don't see the need for this, unless I'm missing something. |
|
Retracting |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
Fe32::ZEROconst, which is the same asFe32::Q, but with more intuitive name.Also replace
Fe32::QtoFe32::ZEROin a few relevant places.