-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HexToArrayError
should not wrap HexToBytesError
#60
Comments
I agree that the issue is correct but posit that the current code is still technically correct. If fixing as suggested makes the generics any more complicated than they already are then I think it should be left as is. |
I don't see how it has anything to do with generics. Just modify the variants of the enum and panic during conversion. Unless you want to avoid the panic but we can still do that without complicating the public API by calling into an inner function after checking the length which only returns errors for invalid characters. |
As I suspected this issue is curly. I've had a bunch of goes at it. I am sick right now though. |
@tcharding I think we can close this issue - it was fixed in #80 |
Mad, thanks. |
HexToBytesError
contains odd length variant which is unreachable when parsing array - it's just invalid length.We should put invalid char directly into
HexToArrayError
and panic during conversion if necessary.The text was updated successfully, but these errors were encountered: