Use configure_me to configure the proxy
#62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If you would like to explicitly ignore these lints in the CI you may. |
|
Yes, I'll have to. I forgot to do that and had a bunch of stuff going on. (I still do though.) |
|
Oh, I though I'd just use the CI to check the crate but it looks like it requires CI approval. |
The proxy used a fixed port for configuration which would be a problem if the user ran a service on the same port already. This change allows the user to configure the port using `configure_me` which supports passing arguments, environment variables or configuration files.
Kixunil
force-pushed
the
configure_me
branch
from
53f29de
to
7edab43
Compare
|
Rather than putting |
|
ACK 7edab43 Gave it a whirl locally and worked well for me. BTW, cool project @Kixunil , reminds me of a Golang version I have been using for years: https://github.com/peterbourgon/ff |
|
Thank you for your contribution! |
|
I'm happy to help. I'm going to need your code, so I need to resolve outstanding issues first. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The proxy used a fixed port for configuration which would be a problem if the user ran a service on the same port already. This change allows the user to configure the port using
configure_mewhich supports passing arguments, environment variables or configuration files.BTW nice that you've made the proxy, I'll need it soon.