Add MSRV build to CI #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were not testing MSRV 1.56.1 before due to a build failure. This allowed a bit of feature creap which relies on newer versions of Rust. Luckily, it was a single feature in our unit tests, so easy to refactor. Now enforcing the MSRV in CI, but this did require us to use precise versions of memchr and backtrace. Currently controlled by our lock file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Locked the two dependencies which were causing issues building on MSRV of 1.56.1:
This is currently only enforced with the lockfile, not sure how fragile that is.
Closes #49