Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mishandling error when the page parameter is not a hash #48

Open
camilo220 opened this issue Aug 6, 2020 · 0 comments
Open

Mishandling error when the page parameter is not a hash #48

camilo220 opened this issue Aug 6, 2020 · 0 comments

Comments

@camilo220
Copy link

If you set the request handler configuration to config.raise_jsonapi_errors = true and you send the page parameter with anything other than a hash a TypeError: no implicit conversion of Symbol into Integer errors raise instead of the proper Error because the format of the message is the incorrect one:

https://github.com/runtastic/request_handler/blob/master/lib/request_handler/page_parser.rb#L14
https://github.com/runtastic/request_handler/blob/master/lib/request_handler/error.rb#L22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant