Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a jQuery 3 incompatibility #40

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mpavey0
Copy link

@mpavey0 mpavey0 commented Sep 21, 2017

The selector property was dropped from jQuery 3 (see:
https://api.jquery.com/selector/).

In this instance (the removeError method), there is no need
for it in the first place. Instead, we can just use the
jQuery object provided (node).

The selector property was dropped from jQuery 3 (see:
https://api.jquery.com/selector/).

In this instance (the removeError method), there is no need
for it in the first place. Instead, we can just use the
jQuery object provided (node).
@mpavey0
Copy link
Author

mpavey0 commented Sep 21, 2017

Hi @running-coder , seems fairly clear you're no longer actively developing this so not sure whether this PR is helpful but I figured I'd send it over. I'm upgrading my site to jQuery 3 and found some incompatibilities in your library. This was a fairly easy fix, though it looks like there are lots of other instances of node.selector still present which probably require more careful thought.

I didn't attempt to build the dist versions, looks like you may have some custom steps in place to remove the debug code, comments, etc.?

Looks like you removed the Issues section from the Github repo? 😢 I know you mentioned you had planned to rewrite the library in ES6 soon…any updates on that? 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant