ci: add workaround for WSL hanging in CI #993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austinvazquez
force-pushed
the
debug-windows-test-vm-lockup
branch
8 times, most recently
from
bc59409
to
73900bc
Compare
austinvazquez
changed the title
austinvazquez
force-pushed
the
debug-windows-test-vm-lockup
branch
from
73900bc
to
fc3240d
Compare
1 task
austinvazquez
force-pushed
the
debug-windows-test-vm-lockup
branch
4 times, most recently
from
a6180de
to
5b9f8ed
Compare
Signed-off-by: Austin Vazquez <[email protected]>
austinvazquez
force-pushed
the
debug-windows-test-vm-lockup
branch
from
5b9f8ed
to
d6dde28
Compare
pendo324
approved these changes
Jun 26, 2024
From the microsoft/WSL issue, some users reported shutdown taking 2-3 minutes. We can also consider being more aggressive than this and killing the WSL service faster. |
sondavidb
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
There is a known issue, microsoft/WSL#8529, where WSL commands can hang. This can cause Windows e2e tests to block until hitting the 2 hour timeout.
Description of changes:
This change adds a workaround to detect the bad state and attempt to mitigate by killing the WSL service. If the issue cannot be resolved, the test will only hang for 300 seconds before failing.
Testing done:
CI run was successful with 8 WSL shutdown failures.
https://github.com/runfinch/finch/actions/runs/9682445232/job/26715743040
Trade-off analysis
The trade-off for this approach is the test suite can take longer with multiple reset VM calls being made. Sample runs which previously took ~15 minutes are up to ~37 minutes with the hanging mitigation; however, this is down from the 2 hour timeout failure which would occur without the mitigation.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.