ci: Make unsigned MSI has timestamp in its name to easily unique fetch it back #636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tify it Signed-off-by: [email protected] <[email protected]>
vsiravar
pushed a commit
that referenced
this pull request
Oct 17, 2023
…h it back (#636) *Description of changes:* When uploading the unsigned to S3, the signer will assign a random postfix to the original MSI. However, since 0.0.0 is a common test install name, it is hard to uniquely identify the signed MSI since there can be historical ones. Added timestamp in the name so that it can be easily fetched back. *Testing done:* Tested with this action run: https://github.com/runfinch/finch/actions/runs/6503614023/job/17664348385 - [X] I've reviewed the guidance in CONTRIBUTING.md #### License Acceptance By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. --------- Signed-off-by: [email protected] <[email protected]> Co-authored-by: [email protected] <[email protected]>
vsiravar
pushed a commit
that referenced
this pull request
Oct 17, 2023
…h it back (#636) *Description of changes:* When uploading the unsigned to S3, the signer will assign a random postfix to the original MSI. However, since 0.0.0 is a common test install name, it is hard to uniquely identify the signed MSI since there can be historical ones. Added timestamp in the name so that it can be easily fetched back. *Testing done:* Tested with this action run: https://github.com/runfinch/finch/actions/runs/6503614023/job/17664348385 - [X] I've reviewed the guidance in CONTRIBUTING.md #### License Acceptance By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. --------- Signed-off-by: [email protected] <[email protected]> Co-authored-by: [email protected] <[email protected]> Signed-off-by: Vishwas Siravara <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
When uploading the unsigned to S3, the signer will assign a random postfix to the original MSI.
However, since 0.0.0 is a common test install name, it is hard to uniquely identify the signed MSI since there can be historical ones. Added timestamp in the name so that it can be easily fetched back.
Testing done:
Tested with this action run: https://github.com/runfinch/finch/actions/runs/6503614023/job/17664348385
License Acceptance
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.