ci: add ShellCheck to CI #458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austinvazquez
force-pushed
the
add-shellcheck
branch
3 times, most recently
from
90ca4c0
to
51091e6
Compare
ginglis13
previously approved these changes
Jun 26, 2023
austinvazquez
force-pushed
the
add-shellcheck
branch
from
51091e6
to
6b0fe0d
Compare
austinvazquez
changed the title
austinvazquez
force-pushed
the
add-shellcheck
branch
from
6b0fe0d
to
76dc857
Compare
austinvazquez
changed the title
austinvazquez
force-pushed
the
add-shellcheck
branch
2 times, most recently
from
6b98162
to
f4f2c0f
Compare
Signed-off-by: Austin Vazquez <[email protected]>
austinvazquez
force-pushed
the
add-shellcheck
branch
from
f4f2c0f
to
0bdd47a
Compare
ginglis13
approved these changes
Aug 30, 2023
pendo324
approved these changes
Aug 31, 2023
ginglis13
pushed a commit
to ginglis13/finch
that referenced
this pull request
Sep 27, 2023
Issue #, if available: N/A *Description of changes:* Adds ShellCheck, a bash scripting linter, to CI as a non-critical step and resolves some of the trivial warnings/issues found by the tool. Another round of fixes is needed for some of the non-trivial warnings/issues. *Testing done:* - [x] I've reviewed the guidance in CONTRIBUTING.md #### License Acceptance By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. Signed-off-by: Austin Vazquez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
Adds ShellCheck, a bash scripting linter, to CI as a non-critical step and resolves some of the trivial warnings/issues found by the tool. Another round of fixes is needed for some of the non-trivial warnings/issues.
Testing done:
License Acceptance
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.