fix: add ci.yaml to exclude from ci-docs triggers #1163
Closed
+49
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shubhranshu153
force-pushed
the
feat-coverage-check
branch
3 times, most recently
from
66e43e1
to
428e29b
Compare
Signed-off-by: Shubharanshu Mahapatra <[email protected]>
Shubhranshu153
force-pushed
the
feat-coverage-check
branch
from
428e29b
to
c27e2a5
Compare
Shubhranshu153
changed the title
|
Is the PR title wrong? I see more changes than just excluding ci.yaml in ci-docs |
pendo324
reviewed
Nov 1, 2024
| @@ -201,7 +203,36 @@ jobs: | |||
| arch: ${{ matrix.arch }} | |||
| version: ${{ matrix.version }} | |||
| runner-type: ${{ matrix.runner-type }} | |||
|
|
|||
| macos-unit-test-coverage: | |||
| runs-on: macos-latest | |||
There was a problem hiding this comment.
We should just add a unit-test-coverage step to the existing unit-tests workflow, instead of creating an entirely new workflow.
We also don't even need to use multiple runners for this, we can use the default ubuntu-latest and set GOOS as needed, per platform, like the linting workflow
There was a problem hiding this comment.
noted, this i meant to try out things only intention was the exclude, but if we have it in the unit test flow we probably dont need it will cancel this one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Add ci.yaml to exclude from ci-docs triggers
Testing done:
License Acceptance
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.