Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow user configurable docker compose version env variable #1133

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

Shubhranshu153
Copy link
Contributor

Issue #, if available:

Description of changes:

Dev containers depends on docker compose version to name their applications. So sending nerdctl compose version breaks functionality

Testing done:

  1. Run with dockercompat flag and env variable set
  2. Run with dockercompat flag and no env variable set
  3. Run without dockercompat flag.
  • I've reviewed the guidance in CONTRIBUTING.md

License Acceptance

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

cmd/finch/devcontainer_patch.go Outdated Show resolved Hide resolved
cmd/finch/nerdctl_remote.go Outdated Show resolved Hide resolved
cmd/finch/devcontainer_patch.go Outdated Show resolved Hide resolved
@Shubhranshu153 Shubhranshu153 marked this pull request as ready for review October 8, 2024 16:07
Copy link
Member

@pendo324 pendo324 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, you just need to regenerate the mocks for NerdctlCommandSystemDeps

@Shubhranshu153 Shubhranshu153 merged commit 69b066b into runfinch:main Oct 8, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants