Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for Skilling Boost Reminder #6804

Merged
merged 2 commits into from
Oct 17, 2024
Merged

Conversation

JonneSaloranta
Copy link
Contributor

Update contains:

  • Fixes for detecting fishing and woodcutting correctly.
  • Update values in config to make them more coherent
  • Fixing notifier arrow positioning

Fixed an issue with detecting when the player is fishing or woodcutting. Updated config also
@runelite-github-app
Copy link

Copy link
Member

@iProdigy iProdigy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heads-up: @Range is only enforced when the user changes the config value, so changing the allowed range will not immediately impact saved values that are now outside the accepted range. For offsetY this isn't a huge deal so I'll merge anyways & you can submit an additional patch if desired

@iProdigy iProdigy merged commit efa20c3 into runelite:master Oct 17, 2024
3 checks passed
@JonneSaloranta
Copy link
Contributor Author

@iProdigy For the upcoming patches. What is/are the best way(s) to endorse this in the future?

@iProdigy
Copy link
Member

What is/are the best way(s) to enforce this in the future?

on plugin startUp: if offsetY is negative, then set offsetY to zero (you'll want to inject ConfigManager to achieve this, or modify your config file to have a setter for offsetY)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants