Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create pet-the-capybara #5930

Merged
merged 8 commits into from
May 13, 2024
Merged

Create pet-the-capybara #5930

merged 8 commits into from
May 13, 2024

Conversation

Droei
Copy link
Contributor

@Droei Droei commented Apr 25, 2024

Simple plugin making it possible for users to pet a capybara and say a cute message on the client side.

@runelite-github-app
Copy link

runelite-github-app bot commented Apr 25, 2024

@Droei
Copy link
Contributor Author

Droei commented Apr 25, 2024

Its my first time working with these checks, I'll close and retry with a fix for the error!

@Droei Droei closed this Apr 25, 2024
@raiyni
Copy link
Member

raiyni commented Apr 25, 2024

Do not use the net.runelite.client.plugins package space

@Nightfirecat
Copy link
Member

FYI you do not need to close this PR; just push updated commits which fix the errors, and we'll review it once it's passing CI

@Nightfirecat Nightfirecat reopened this Apr 25, 2024
@Droei
Copy link
Contributor Author

Droei commented Apr 25, 2024

Alright I'll keep trying, thanks a lot! (Sorry if this is giving notifications)

@raiyni
Copy link
Member

raiyni commented Apr 26, 2024

This can be reduced to use MenuEntryAdded if you care enough.

@Droei
Copy link
Contributor Author

Droei commented Apr 26, 2024

I'd be up to improve the code anytime, its a big learning curve for me!
Do you by any chance know a plugin that uses the constructor so I can look into it?

@YvesW
Copy link
Member

YvesW commented Apr 26, 2024

It's generally best to clone core and check out some core plugins. Ctrl+shift+f in IJ

@Droei
Copy link
Contributor Author

Droei commented Apr 26, 2024

Thanks for the feedback! MenuEntryAdded is now used instead of onMenuOpened and I made the code a bit more presentable.

@raiyni
Copy link
Member

raiyni commented May 2, 2024

My first comment is still valid.

@Droei
Copy link
Contributor Author

Droei commented May 3, 2024

Ooh I'll look into that tomorrow, I kinda have an idea what you mean but not completely!
If you could clarify what you mean that would help a lot!

@cdfisher
Copy link
Contributor

cdfisher commented May 3, 2024

Ooh I'll look into that tomorrow, I kinda have an idea what you mean but not completely! If you could clarify what you mean that would help a lot!

Your package should be called something like com.droei.petthecapybara

@raiyni raiyni merged commit 2d3f1b2 into runelite:master May 13, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants