Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NPC Animator Plugin #5918

Merged
merged 2 commits into from
May 17, 2024
Merged

Conversation

SomewhatUsefulSoftware
Copy link
Contributor

Lets users set and run animations on NPCs and their own character.

This plugin is intended to be used to make the NPCs feel more alive and to give them a little extra personality. It might also be useful for players who want to make role-playing videos.

Features:

  • Save any animation in the game with your own customizable name for it.
  • Run any animation on your own player.
  • Run any animation on any NPC.
  • Save animations for individual NPCs as 'Greetings'
    • Example: Save the bow animation for King Roald so when you interact with him, he bows to you.
  • Run all saved NPC animations at the same time.
    • Use this to run all the saved greeting animations or just 1 specific animation on all saved NPCs.
  • Run an animation on all spawned NPCs at the same time.

@runelite-github-app
Copy link

runelite-github-app bot commented Apr 22, 2024

@Nightfirecat
Copy link
Member

You're adding a nav button here which is never removed, even on plugin shutdown, so disabling your plugin would not remove this button and toggling it would add multiple buttons. Please ensure it is removed on shutDown().

Remove navigation button on shutdown + small bug fixes
@SomewhatUsefulSoftware
Copy link
Contributor Author

You're adding a nav button here which is never removed, even on plugin shutdown, so disabling your plugin would not remove this button and toggling it would add multiple buttons. Please ensure it is removed on shutDown().

I fixed this as requested and also fixed a UI bug. However, I cannot verify the workflow checks pass as it's awaiting approval from a maintainer.

@Nightfirecat Nightfirecat merged commit a0a410b into runelite:master May 17, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants