Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiwallet Issue #83

Open
juscamarena opened this issue Nov 28, 2018 · 2 comments
Open

Multiwallet Issue #83

juscamarena opened this issue Nov 28, 2018 · 2 comments

Comments

@juscamarena
Copy link
Contributor

Multiwallet support does not support using commands through .command for new rpcs.

For example this command below will fail even with a wallet set.

Checking debug logs shows that in cases with manual commands the wallet path is not added to the url.

client.command('walletprocesspsbt', rawPbstTxn)

@juscamarena juscamarena changed the title Multiwallet Multiwallet Issue Nov 28, 2018
@pedrobranco
Copy link
Collaborator

By the actual implementation, to use that wallet path it is required to be defined in methods.js file, and enable that feature.

Don't know if it is worth to have a walletCommand(wallet, ...args) to allow those calls.

@juscamarena
Copy link
Contributor Author

Yeah, I manually added them to the methods.js as a workaround in a separate branch I kept, I think we should have an walletCommand(wallet, ...args) to allow those calls otherwise this lib needs to be constantly updated ever release to use any new multiwallet commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants