From cc0f8cfa435a20237b27d3a5fe3bf199d1187b43 Mon Sep 17 00:00:00 2001 From: Benjamin Perseghetti Date: Thu, 16 May 2024 15:06:05 -0400 Subject: [PATCH] Apply suggestions from code review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Alejandro Hernández Cordero Signed-off-by: Benjamin Perseghetti --- include/gz/math/Cone.hh | 10 +++++----- include/gz/math/MassMatrix3.hh | 16 ++++++++-------- src/ruby/MassMatrix3.i | 16 ++++++++-------- 3 files changed, 21 insertions(+), 21 deletions(-) diff --git a/include/gz/math/Cone.hh b/include/gz/math/Cone.hh index 58d161f9..da4c9568 100644 --- a/include/gz/math/Cone.hh +++ b/include/gz/math/Cone.hh @@ -57,8 +57,8 @@ namespace gz /// \param[in] _radius Radius of the cone. /// \param[in] _rotOffset Rotational offset of the cone. public: Cone(const Precision _length, const Precision _radius, - const Quaternion &_rotOffset = - Quaternion::Identity); + const Quaternion &_rotOffset = + Quaternion::Identity); /// \brief Construct a cone with a length, radius, material and /// optionally a rotational offset. @@ -67,9 +67,9 @@ namespace gz /// \param[in] _mat Material property for the cone. /// \param[in] _rotOffset Rotational offset of the cone. public: Cone(const Precision _length, const Precision _radius, - const Material &_mat, - const Quaternion &_rotOffset = - Quaternion::Identity); + const Material &_mat, + const Quaternion &_rotOffset = + Quaternion::Identity); /// \brief Get the radius in meters. /// \return The radius of the cone in meters. diff --git a/include/gz/math/MassMatrix3.hh b/include/gz/math/MassMatrix3.hh index 3d63eb70..ed2880b4 100644 --- a/include/gz/math/MassMatrix3.hh +++ b/include/gz/math/MassMatrix3.hh @@ -939,9 +939,9 @@ namespace gz /// \param[in] _rot Rotational offset of equivalent cone. /// \return True if inertial properties were set successfully. public: bool SetFromConeZ(const Material &_mat, - const T _length, - const T _radius, - const Quaternion &_rot = Quaternion::Identity) + const T _length, + const T _radius, + const Quaternion &_rot = Quaternion::Identity) { // Check that density, _radius and _length are strictly positive // and that quaternion is valid @@ -963,9 +963,9 @@ namespace gz /// \param[in] _rot Rotational offset of equivalent cone. /// \return True if inertial properties were set successfully. public: bool SetFromConeZ(const T _mass, - const T _length, - const T _radius, - const Quaternion &_rot = Quaternion::Identity) + const T _length, + const T _radius, + const Quaternion &_rot = Quaternion::Identity) { // Check that _mass, _radius and _length are strictly positive // and that quaternion is valid @@ -985,8 +985,8 @@ namespace gz /// \param[in] _rot Rotational offset of equivalent cone. /// \return True if inertial properties were set successfully. public: bool SetFromConeZ(const T _length, - const T _radius, - const Quaternion &_rot) + const T _radius, + const Quaternion &_rot) { // Check that _mass and _size are strictly positive // and that quaternion is valid diff --git a/src/ruby/MassMatrix3.i b/src/ruby/MassMatrix3.i index 6ef205b4..779751b4 100644 --- a/src/ruby/MassMatrix3.i +++ b/src/ruby/MassMatrix3.i @@ -104,16 +104,16 @@ namespace gz const T _radius, const Quaternion &_rot); public: bool SetFromConeZ(const Material &_mat, - const T _length, - const T _radius, - const Quaternion &_rot = Quaternion::Identity); + const T _length, + const T _radius, + const Quaternion &_rot = Quaternion::Identity); public: bool SetFromConeZ(const T _mass, - const T _length, - const T _radius, - const Quaternion &_rot = Quaternion::Identity); + const T _length, + const T _radius, + const Quaternion &_rot = Quaternion::Identity); public: bool SetFromConeZ(const T _length, - const T _radius, - const Quaternion &_rot); + const T _radius, + const Quaternion &_rot); public: bool SetFromSphere(const Material &_mat, const T _radius); public: bool SetFromSphere(const T _mass, const T _radius); public: bool SetFromSphere(const T _radius);