Add new "Single-line do...end block" rule
#922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koic
force-pushed
the
add_new_single_line_do_end_block_rule
branch
from
934a745
to
a7c5f87
Compare
koic
changed the title
Single-line do...end block ruledo...end block" rule
Follow up rubocop/rubocop#12227 (comment) This PR adds new "Single-line `do`...`end` block" rule. Use multi-line `do`...`end` block instead of single-line `do`...`end` block. ```ruby # bad foo do |arg| bar(arg) end # good foo do |arg| bar(arg) end # bad ->(arg) do bar(arg) end # good ->(arg) { bar(arg) } ```
koic
force-pushed
the
add_new_single_line_do_end_block_rule
branch
from
a7c5f87
to
9719513
Compare
8 tasks
koic
added a commit
to rubocop/rubocop
that referenced
this pull request
Nov 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up rubocop/rubocop#12227 (comment)
This PR adds new "Single-line
do...endblock" rule.Use multi-line
do...endblock instead of single-linedo...endblock.