No cop for expect(foo.empty?).to be(true) or expect(foo.include?(whatever)).to be(true)

[Earlopain]

Hi there, am I missing something or are there just no cops that check for the above code at the moment?

I would expect these corrections:

expect(foo.empty?).to be(true)
expect(foo).to eq('')
# =>
expect(foo).to be_empty

expect(foo.include?(whatever)).to be(true)
# =>
expect(foo).to inlcude(whatever)

The reason for that is that on failure the message is much more explicit instead of just saying that true/false != false/true. There are some cops I would expect to take here like RSpec/PredicateMatcher or RSpec/BeEmpty but that's not happening.

If this is missing at the moment I'd love to implement this myself but will need some guideance to which cops this logic would belong to.

[pirj]

How about setting strict: false on https://docs.rubocop.org/rubocop-rspec/cops_rspec.html#strict-false-enforcedstyle-inflected?

Related issue #919

BeEmpty is about empty arrays, not even Hashes.
A PR with new cops to cover {} and empty string with eq/be is welcome.

[Earlopain]

Yeah, I tried changing the settings of that cop but I'm not getting any new offenses with that.

Nice to know I at least didn't overlook something for the empty string case. I'll try to make a PR for that, thanks.