-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add common method getType to ReactionType interface #1382
base: dev
Are you sure you want to change the base?
Conversation
Not a big fan of making a generated override for an interface method. The getter is generated in the subtypes using Lombok. I'd argue for explicitly implementing the getter in this case to make the inheritance clearer @rubenlagus your opinion? |
@Chase22, this change helps to quickly check a type of reaction by using a getter instead of ugly Lines 16 to 24 in 7d50276
Literally the same was done here: Lines 18 to 28 in 7d50276
And here: Lines 34 to 50 in 7d50276
|
3331463
to
a017c98
Compare
68a6f61
to
5fc7d88
Compare
No description provided.