Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Config for maximum duration #168

Open
nerdiges opened this issue Jun 1, 2020 · 2 comments
Open

Feature Request: Config for maximum duration #168

nerdiges opened this issue Jun 1, 2020 · 2 comments

Comments

@nerdiges
Copy link

nerdiges commented Jun 1, 2020

Would it be possible to have a configuration option to restrict the maximum duration for the valve e.g in schedules? I would like to use it as an additional saftey maesure to avoid schedules accidentially configured to open the valve for 200+ minutes.

Best would be an configuration option in the settings page, but an alternative option could be a setting in the config.h

Thank you for your efforts,
Stephan

@nhorvath
Copy link
Collaborator

nhorvath commented Jun 1, 2020

I'll consider this but for now if you want you can edit the "max" parameter of this line in your local copy:
https://github.com/rszimm/sprinklers_pi/blob/master/web/ShSched.htm#L113

@nerdiges
Copy link
Author

nerdiges commented Jun 1, 2020

Thank you for your quick response. I already implemented your recommended work around in ShSched.htm and QSched.htm and it's restricted on the web interface as excpected.

Nevertheless, a restriction in the binary could also restrict any duration provided via API. Would be handy for any integration in a hom automation software suchu as home assistant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants