Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error messages in onError and in onNext #205

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ScavengerSpb
Copy link

@ScavengerSpb ScavengerSpb commented Jan 5, 2022

State error messages Flowable: Invalid call to onXxx(): onComplete/onError was already called.' / Flowable: Invalid call to onXxx(): onSubscribe has not been called.' are printed correctly now in onError and onNext methods.

Motivation:

Previously, state error message Flowable: Invalid call to onXxx(): onSubscribe has not been called.' was printed always regardles of the actual state of FlowableSubscriber. Even on attempt to operate on FlowableSubscriber when flow was completed already (either by prior call to onError or onComplete method).

Note: State error message in onComplete method works correctly already.

Modifications:

Checks for this._active are replaced with this._started.

Result:

State error message Flowable: Invalid call to onXxx(): onComplete/onError was already called.' is printed on attempt to operate on FlowableSubscriber when flow is completed already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant