Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server does not close and re-connect on no keep alive ack issue. #1099

Open
pstreef opened this issue Dec 19, 2023 · 0 comments
Open

Server does not close and re-connect on no keep alive ack issue. #1099

pstreef opened this issue Dec 19, 2023 · 0 comments

Comments

@pstreef
Copy link

pstreef commented Dec 19, 2023

Using the server setup found here and using rsocket-core 1.1.3 my server behaves as expected. If for some reason no acks get delivered during the keep-alive timeout it will restart the connection. In 1.1.4 this no longer works.

Expected Behavior

After:

io.rsocket.exceptions.ConnectionErrorException: No keep-alive acks for x ms

I expect that the connection is closed and my client can reconnect.

Actual Behavior

In 1.1.4 the client RSocketRequester does not properly reset the connection and the next call fails with the same ConnectionErrorException

Steps to Reproduce

I've created a small reproducing example. The test in this projects runs green using rsocket-core 1.1.3, but fails when using 1.1.4

Possible Solution

I believe this is regression from this change.

Your Environment

See sample project

  • RSocket version(s) used: 1.1.4 (and 1.1.3)
  • Other relevant libraries versions (eg. netty, ...): spring-boot-starter-rsocket 3.2.0
  • Platform (eg. JVM version (javar -version) or Node version (node --version)): zulu 17.0.8
  • OS and version (eg uname -a): macos 14.2 (23C64)
@rstoyanchev rstoyanchev added this to the 1.1.5 milestone Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants