feat: add missing error consumer setter on connector #24
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, there is no way to receive and/or handle setup rejection errors because the error consumer of the RSocketConnector is always null
Motivation:
The
connect
function of theRSocketConnector
sets theerrorConsumer
while thereceiveFrame
function of theRSocketRequester
passes an error frame to theerrorConsumer
to handle the error. The problem is that the_errorConsumer
of theRSocketConnecter
has no setter and will always be null. So, users will not be able to receive and/or handle the error, for example when they receive a setup rejection error.Modifications:
Adds a setter for the RSocketConnector's error consumer.
Result:
Now users can receive & handle setup errors correctly