Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add missing error consumer setter on connector #24

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

petragabriela
Copy link

Currently, there is no way to receive and/or handle setup rejection errors because the error consumer of the RSocketConnector is always null

Motivation:

The connect function of the RSocketConnector sets the errorConsumer while the receiveFrame function of the RSocketRequester passes an error frame to the errorConsumer to handle the error. The problem is that the _errorConsumer of the RSocketConnecter has no setter and will always be null. So, users will not be able to receive and/or handle the error, for example when they receive a setup rejection error.

Modifications:

Adds a setter for the RSocketConnector's error consumer.

Result:

Now users can receive & handle setup errors correctly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant