Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for wildcards for --exclude #265

Closed
rrd108 opened this issue Sep 11, 2024 · 4 comments · Fixed by #306
Closed

add support for wildcards for --exclude #265

rrd108 opened this issue Sep 11, 2024 · 4 comments · Fixed by #306
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed P3 Low priority

Comments

@rrd108
Copy link
Owner

rrd108 commented Sep 11, 2024

For example we have rule.ts and rule.test.ts files in the same directory.

With this change we can run yarn analyze --exclude=*test.ts and all files what match the pattern could be excluded.

@David-Pena David-Pena added enhancement New feature or request help wanted Extra attention is needed P3 Low priority labels Sep 12, 2024
@David-Pena David-Pena self-assigned this Sep 21, 2024
@David-Pena
Copy link
Collaborator

it('should execute with exclude wildcard for test files', async () => {
    const { stdout } = await execa('yarn', ['analyze', '--exclude=*.test.ts'])
    expect(stdout).toContain('Excluding *.test.ts')
})

🚀 image

@David-Pena
Copy link
Collaborator

image

good enough for another PR

@rrd108
Copy link
Owner Author

rrd108 commented Sep 21, 2024

You rock today 🎉

@David-Pena
Copy link
Collaborator

David-Pena commented Sep 21, 2024

I created a PR for this @rrd108

Sorry I havent seen your comment haha, it was a productive night 🥳

rrd108 added a commit that referenced this issue Sep 21, 2024
…xclude-flag

feat: add support for wildcards in `--exclude` flag (#265)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed P3 Low priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants