Allow users to provide their own Docker credentials #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gw0
commented
Feb 18, 2021
| elif [[ "a${ALLOW_PUSH_WITH_OWN_AUTH}" == "atrue" ]]; then | ||
| cat << 'EOF' > /etc/nginx/conf.d/allowed.methods.conf | ||
| # Block POST/PUT/DELETE if own authentication is not provided. | ||
| set $combined_ha_rm "$http_authorization$request_method"; |
There was a problem hiding this comment.
Workaround is needed, because Nginx does not support multiple conditions and not even nested if-clauses (https://ezecodes.wordpress.com/2016/06/30/multiple-if-conditions-in-nginx/).
This was referenced Feb 18, 2021
Open
|
I know this is probably not the right place, but thank you @gw0! Since we switched to OCI for our image repository I couldn't use the proxy anymore (couldn't get the auth to work), but with your fork it works like a charm :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two configurable options that allow users to provide their own Docker credentials:
ALLOW_OWN_AUTH(defaultfalse): Allow overriding theAUTH_REGISTRIESauthentication with own Docker credentials if provided (to supportdocker loginas another user). (Fixes Allow docker-client to use its own authentication (docker login), if present, otherwise use configured registry auth #61)ALLOW_PUSH_WITH_OWN_AUTH(defaultfalse): Allow bypassing the proxy when pushing only if own authentication is provided.