refactoring: Address, AssignVehicle, DriversScheduleswithTerritoriesV… #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…3, GetOrdersByCustomFields, OrdersManager, PickupDropoffJoint, RoutingManager, TelematicsGetVendorInfo, TelematicsManager
r4m-juan
commented
Dec 20, 2023
| @@ -160,7 +160,7 @@ public static void main(String[] args) { | |||
| optParameters.setAddresses(addresses); | |||
|
|
|||
| try { | |||
| DataObject responseObject = manager.runOptimization(optParameters); | |||
| DataObject responseObject = manager.runOptimizationWithRedirect0(optParameters); | |||
There was a problem hiding this comment.
This is not needed we have this method:
public RoutingManager(String apiKey, boolean disableRedirects) {
super(apiKey, disableRedirects);
}
to disabled redirects
When that method is used we do this:
if (this.disableRedirects) {
builder.addParameter("redirect", "0");
client = HttpClients.custom().disableRedirectHandling().build();
}
There was a problem hiding this comment.
Yes, you are right, I missed this
| @@ -22,8 +22,8 @@ public static void main(String[] args) { | |||
| TelematicsManager manager = new TelematicsManager(apiKey); | |||
|
|
|||
| try { | |||
| TelematicsVendorsInfo vendor = manager.getTelematicsVendorInfo("3"); | |||
| System.out.println(vendor.getVendor()); | |||
| TelematicsVendorInfo vendor = manager.getTelematicsVendorInfo("3", "62f6197505da3f545c4fc9cb87ae76c9"); | |||
There was a problem hiding this comment.
@r4m-cristianv Why you added this uuid key here
There was a problem hiding this comment.
I was getting unauthorized access error, that is why I added this api token, but now I double checked and the test passed without api token, so I removed it
| @@ -65,6 +65,12 @@ public DataObject runOptimization(OptimizationParameters parameters) throws APIE | |||
| URIBuilder builder = Manager.defaultBuilder(OPTIMIZATION_EP); | |||
| return this.makeJSONRequest(RequestMethod.POST, builder, parameters, DataObject.class); | |||
| } | |||
|
|
|||
| public DataObject runOptimizationWithRedirect0(OptimizationParameters parameters) throws APIException { | |||
There was a problem hiding this comment.
This is not needed @r4m-cristianv
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…3, GetOrdersByCustomFields, OrdersManager, PickupDropoffJoint, RoutingManager, TelematicsGetVendorInfo, TelematicsManager