Fix issue 80: Weather packet decoding. #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Weather packets were being decoded incorrectly. Over the air packets for weather are in wind miles per hour. Rain is in hundreths of an inch according to the official spec. This patch changes the weather packet output to include the wind_speed and wind_direction as part of the weather dict in the packet instead of course and speed. According to the APRS Spect CSE/SPD for weather packets, which are denoted with the _ character are supposed to be used for wind speed and wind direction. "The on-air APRS WX protocols, however, still will be in MPH and F." "RAIN VALUES: Rain is counted in increments of 0.1 or 0.01 inch or 1mm. but reports all values in 0.01 inches over the air." References: http://www.aprs.org/APRS-docs/WX.TXT
hemna
added a commit
to craigerl/aprsd
that referenced
this pull request
Jul 13, 2023
aprslib incorrectly decodes weather packets and doesn't provide wind_speed or wind_direction from the CSE/SPD 7 bytes in the APRS packet. This patch puts a temporary fix in place until the aprslib pull request lands and is released. rossengeorgiev/aprs-python#80 rossengeorgiev/aprs-python#81
hemna
added a commit
to craigerl/aprsd
that referenced
this pull request
Jul 13, 2023
aprslib incorrectly decodes weather packets and doesn't provide wind_speed or wind_direction from the CSE/SPD 7 bytes in the APRS packet. This patch puts a temporary fix in place until the aprslib pull request lands and is released. rossengeorgiev/aprs-python#80 rossengeorgiev/aprs-python#81
shackrat
added a commit
to shackrat/aprs-python
that referenced
this pull request
Sep 14, 2023
Implements: Fix issue 80: Weather packet decoding. rossengeorgiev#81
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Weather packets were being decoded incorrectly. Over the air packets for weather are in wind miles per hour. Rain is in hundreths of an inch according to the official spec.
This patch changes the weather packet output to include the wind_speed and wind_direction as part of the weather dict in the packet instead of course and speed. According to the APRS Spect CSE/SPD for weather packets, which are denoted with the _ character are supposed to be used for wind speed and wind direction.
"The on-air APRS WX protocols, however, still will be in MPH and F."
"RAIN VALUES: Rain is counted in increments of 0.1 or 0.01 inch or 1mm. but reports all values in 0.01 inches over the air."
References:
http://www.aprs.org/APRS-docs/WX.TXT
Fixes issue #80