Fix zenoh shutdown #550
Draft
Fix zenoh shutdown #550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
fujitatomoya
reviewed
Oct 4, 2024
| sys.exit(1) | ||
|
|
||
| rclpy.spin(node) | ||
| rclpy.init(args=[]) |
There was a problem hiding this comment.
what happens with zenoh if we use contextmanager manner with InitContextManager? i am not sure if this change is needed here because both call cleanup process through the context.
There was a problem hiding this comment.
Yes, exactly, this should not be needed. Going forward, our recommended pattern in rclpy is to use the context manager with rclpy.init, so if that is not working, there is a bug somewhere that needs to be fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix zenoh shutdown
Related with ros2/rmw_zenoh#276