Replace deprecated spin_until_future_complete #1600
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christophe Bedard <[email protected]>
christophebedard
requested review from
gbiggs and
jhdcs
and removed request for
a team
MichaelOrlov
approved these changes
Apr 3, 2024
There was a problem hiding this comment.
@christophebedard Overall I don't mind with this replacement.
However, would like to know, what was the motivation for this replacement?
What's wrong with the original spin_until_future_complete(..) API?
See the discussion in ros2/rclcpp#2475 (comment) ; I'm not yet convinced that we should do this. |
|
As per the discussion in ros2/rclcpp#2475 (comment), we will not be doing this. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires ros2/rclcpp#2475
Part of ros2/rclcpp#2475